Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): proposal template drafting #1330

Merged
merged 30 commits into from
Jan 1, 2025
Merged

feat(docs): proposal template drafting #1330

merged 30 commits into from
Jan 1, 2025

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Dec 4, 2024 •
edited by nathanbogale
Loading

Description of Changes

Includes the proposal schema json template for rendering and validating proposals, primarily to be used on the proposal builder page

  • My code follows the style guidelines of this project
  • have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj marked this pull request as draft December 4, 2024 17:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@minikin minikin added the draft Draft label Dec 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 333/333}$ | ${\color{red}Fail: 0/333}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

✅ Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

@nathanbogale nathanbogale added review me PR is ready for review and removed draft Draft F14 labels Dec 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

@minikin minikin marked this pull request as ready for review January 1, 2025 16:21
nathanbogale
nathanbogale previously approved these changes Jan 1, 2025
View reviewed changes
minikin
minikin reviewed Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me.
Why do we need to update package.json files?

@nathanbogale
Copy link
Contributor

@minikin

Overall, it looks good to me. Why do we need to update package.json files?
I suppose it came from main or automated or on build, package files in this branch are now aligned and are same with main

@nathanbogale nathanbogale reopened this Jan 1, 2025
@minikin minikin enabled auto-merge (squash) January 1, 2025 18:27
@minikin minikin self-requested a review January 1, 2025 18:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

✅ Test Report | ${\color{lightgreen}Pass: 370/370}$ | ${\color{red}Fail: 0/370}$ |

@minikin minikin merged commit 9c6b253 into main Jan 1, 2025
76 of 78 checks passed
@minikin minikin deleted the feat/proposal-template-drafting branch January 1, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LynxLynxx LynxLynxx LynxLynxx left review comments

@neil-iohk neil-iohk neil-iohk left review comments

@minikin minikin minikin approved these changes

@nathanbogale nathanbogale nathanbogale left review comments

@dtscalac dtscalac Awaiting requested review from dtscalac

@damian-molinski damian-molinski Awaiting requested review from damian-molinski

Assignees

@nathanbogale nathanbogale

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Proposal Submission & Commentary ...
Development

Successfully merging this pull request may close these issues.
5 participants
@stevenj @minikin @nathanbogale @LynxLynxx @neil-iohk